Postgres Pro
Downloads
Home   >   mailing lists

Thread: PATCH: Stored procedure large parameter list

PATCH: Stored procedure large parameter list

From
"J.F. Oster"
Date:
Hello!

Please consider this patch. It's a small formatting improvement for
pgFunction::GetSql() per discussion:
http://www.postgresql.org/message-id/CAHYn==4bqLjo5Y+AgaNC-HWrtKHPyDUueQ_NvbPBPYPb5JRtHA@mail.gmail.com

--
Best regards,
 J.F.
Attachment

Re: PATCH: Stored procedure large parameter list

From
inspector morse
Date:
Oh thank god! We have like 80+ stored procedures with very long parameter lists. Editing them is a nightmare cause it is listed out horizontally in pgadmin. We tried using text files instead but they often become out of sync due to developers not keeping them upto date.

Do you know if this will be integrated in the next version of Debian (Jessie)? We're currently using Debian Wheezy.

On Sun, Oct 26, 2014 at 1:51 AM, J.F. Oster <jinfroster@mail.ru> wrote:
Hello!

Please consider this patch. It's a small formatting improvement for
pgFunction::GetSql() per discussion:
http://www.postgresql.org/message-id/CAHYn==4bqLjo5Y+AgaNC-HWrtKHPyDUueQ_NvbPBPYPb5JRtHA@mail.gmail.com

--
Best regards,
 J.F.

Re: PATCH: Stored procedure large parameter list

From
Dave Page
Date:
Ashesh, can you review/commit this please?

On Sun, Oct 26, 2014 at 5:51 AM, J.F. Oster <jinfroster@mail.ru> wrote:
> Hello!
>
> Please consider this patch. It's a small formatting improvement for
> pgFunction::GetSql() per discussion:
> http://www.postgresql.org/message-id/CAHYn==4bqLjo5Y+AgaNC-HWrtKHPyDUueQ_NvbPBPYPb5JRtHA@mail.gmail.com
>
> --
> Best regards,
>  J.F.
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Stored procedure large parameter list

From
Sanket Mehta
Date:
Hi

I have reviewed this patch.
This looks good to me.


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Oct 27, 2014 at 4:16 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit this please?

On Sun, Oct 26, 2014 at 5:51 AM, J.F. Oster <jinfroster@mail.ru> wrote:
> Hello!
>
> Please consider this patch. It's a small formatting improvement for
> pgFunction::GetSql() per discussion:
> http://www.postgresql.org/message-id/CAHYn==4bqLjo5Y+AgaNC-HWrtKHPyDUueQ_NvbPBPYPb5JRtHA@mail.gmail.com
>
> --
> Best regards,
>  J.F.
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: PATCH: Stored procedure large parameter list

From
Ashesh Vashi
Date:
Committed with small modification.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Tue, Oct 28, 2014 at 2:59 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi

I have reviewed this patch.
This looks good to me.


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Oct 27, 2014 at 4:16 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/commit this please?

On Sun, Oct 26, 2014 at 5:51 AM, J.F. Oster <jinfroster@mail.ru> wrote:
> Hello!
>
> Please consider this patch. It's a small formatting improvement for
> pgFunction::GetSql() per discussion:
> http://www.postgresql.org/message-id/CAHYn==4bqLjo5Y+AgaNC-HWrtKHPyDUueQ_NvbPBPYPb5JRtHA@mail.gmail.com
>
> --
> Best regards,
>  J.F.
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: PATCH: Stored procedure large parameter list

From
Raymond O'Donnell
Date:
On 28/10/2014 11:36, Ashesh Vashi wrote:
> Committed with small modification.
>

Brilliant! Thanks everyone.

Ray.

--
Raymond O'Donnell :: Galway :: Ireland
rod@iol.ie

Re: PATCH: Stored procedure large parameter list

From
inspector morse
Date:
Hello,

Does anyone know if this will be put in Debian Wheezy (stable)? How do we get it into Debian Wheezy?

I asked the Debian pgAdmin package maintainer and he told me to ask the pgamdin mailing list instead.

Thanks!

On Tue, Oct 28, 2014 at 7:39 AM, Raymond O'Donnell <rod@iol.ie> wrote:
On 28/10/2014 11:36, Ashesh Vashi wrote:
> Committed with small modification.
>

Brilliant! Thanks everyone.

Ray.

--
Raymond O'Donnell :: Galway :: Ireland
rod@iol.ie

Re: PATCH: Stored procedure large parameter list

From
Dave Page
Date:
On Tue, Oct 28, 2014 at 3:24 PM, inspector morse
<inspectormorse86@gmail.com> wrote:
> Hello,
>
> Does anyone know if this will be put in Debian Wheezy (stable)? How do we
> get it into Debian Wheezy?
>
> I asked the Debian pgAdmin package maintainer and he told me to ask the
> pgamdin mailing list instead.

We've have nothing to do with the Debian packaging. The only way it'll
get into there is if they package 1.20, or backpatch the changes
themselves.

> On Tue, Oct 28, 2014 at 7:39 AM, Raymond O'Donnell <rod@iol.ie> wrote:
>>
>> On 28/10/2014 11:36, Ashesh Vashi wrote:
>> > Committed with small modification.
>> >
>>
>> Brilliant! Thanks everyone.
>>
>> Ray.
>>
>> --
>> Raymond O'Donnell :: Galway :: Ireland
>> rod@iol.ie
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: Stored procedure large parameter list

From
inspector morse
Date:
Oh ok, thanks all for your work on the patch and getting it comitted.


On Tue, Oct 28, 2014 at 11:32 AM, Dave Page <dpage@pgadmin.org> wrote:
On Tue, Oct 28, 2014 at 3:24 PM, inspector morse
<inspectormorse86@gmail.com> wrote:
> Hello,
>
> Does anyone know if this will be put in Debian Wheezy (stable)? How do we
> get it into Debian Wheezy?
>
> I asked the Debian pgAdmin package maintainer and he told me to ask the
> pgamdin mailing list instead.

We've have nothing to do with the Debian packaging. The only way it'll
get into there is if they package 1.20, or backpatch the changes
themselves.

> On Tue, Oct 28, 2014 at 7:39 AM, Raymond O'Donnell <rod@iol.ie> wrote:
>>
>> On 28/10/2014 11:36, Ashesh Vashi wrote:
>> > Committed with small modification.
>> >
>>
>> Brilliant! Thanks everyone.
>>
>> Ray.
>>
>> --
>> Raymond O'Donnell :: Galway :: Ireland
>> rod@iol.ie
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company