Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

[pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

From
Teng Zhang
Date:
Hi Hackers,

Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords.

- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum
- No behavior change to pg and ppas, still use "x-pgsql"

Regards,
Hao Wang & Teng Zhang


Attachment

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sqleditor

From
Jing Li
Date:
a {word-wrap:normal;word-break:break-word;}.background-contain {background-size:contain;}@media only screen and (max-width:600px) {.container {-webkit-text-size-adjust:none !important;}.container,.palm-one-whole {width:100% !important;min-width:100% !important;}.palm-one-half {width:50% !important;min-width:50% !important;box-sizing:border-box;}blockquote .container,blockquote .container div,blockquote .container table {width:auto !important;min-width:0 !important;position:relative !important;}img {max-width:100%;}.border-outer,.border-middle,.border-inner,.inner,[title="separator"] {width:100% !important;}.innercell {padding:8px !important;}.palm-block {display:block !important;}td.palm-one-whole {display:inline-block !important;padding:0;}td.palm-one-whole:first-child:not(:only-child) {margin-bottom:16px;}td.hostname {padding-top:3px !important;}}@media only screen and (min-width:601px) {.preview-card {max-width:600px !important;}}@media only screen and (min-device-width :320px) and (max-device-width :568px),only screen and (min-device-width :768px) and (max-device-width :1024px),only screen and (max-device-width:640px),only screen and (max-device-width:667px),only screen and (max-width:480px){.container {width:100% !important;min-width:100% !important;}.p,.small,li,font[size="2"],font[size="3"] {font-size:1em !important;}}@media only screen and (min-device-width :320px) and (max-device-width :568px),only screen and (min-device-width :768px) and (max-device-width :1024px),only screen and (min-device-width :1224px) {.message-wrapper {padding-top:6px;}.apple-only[style] {display:block !important;max-height:none !important;line-height:normal !important;overflow:visible !important;height:auto !important;width:100% !important;position:relative !important;}.no-apple {display:none !important;}form {font-size:inherit;}input[type="text"] {height:43px;padding-left:4px !important;}button:hover {cursor:pointer;}}@media only screen and (min-device-width :1224px) {.apple-mail-form {display:block !important;background-color:white !important;}}* [office365] .outlook-com-hidden {display:none !important;}* [office365] .outlook-com-button {display:block;}* [office365] .outlook-com-only {display:block !important;max-height:none !important;line-height:normal !important;overflow:visible !important;height:auto !important;width:100% !important;position:relative !important;}.ExternalClass {width:100%;}.ExternalClass .outlook-com-button {display:block;}.ExternalClass button {height:auto;}.ExternalClass .outlook-com-hidden {display:none !important;}.ExternalClass .outlook-com-only {display:block !important;max-height:none !important;line-height:normal !important;overflow:visible !important;height:auto !important;width:100% !important;position:relative !important;}.ExternalClass .ecxlabels {display:none !important;}.ExternalClass .ecxlabels {display:none !important;}.ExternalClass .ecxarrow {display:none !important;}.ExternalClass cite >div + div {padding:0 0 4px 0;}.ExternalClass .h1 {padding-bottom:5px;}.ExternalClass .h2 {padding-bottom:5px;}.ExternalClass .h3 {padding-bottom:5px;}.ExternalClass [lang="brand-pinterest"] {width:280px !important;}
Can we get this patch into the 2.0 release?



On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezhang@pivotal.io wrote:
Hi Hackers,

Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords.

- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum
- No behavior change to pg and ppas, still use "x-pgsql"

Regards,
Hao Wang & Teng Zhang


Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

From
Dave Page
Date:


On Mon, Sep 11, 2017 at 11:13 AM, Jing Li <jingli@pivotal.io> wrote:
Can we get this patch into the 2.0 release?

Shouldn't be a problem. It didn't make todays build though.
 



On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezhang@pivotal.io wrote:
Hi Hackers,

Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords.

- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum
- No behavior change to pg and ppas, still use "x-pgsql"

Regards,
Hao Wang & Teng Zhang





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

From
Dave Page
Date:
Akshay, can you review/commit this please?

Thanks.

On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang <tezhang@pivotal.io> wrote:
Hi Hackers,

Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords.

- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum
- No behavior change to pg and ppas, still use "x-pgsql"

Regards,
Hao Wang & Teng Zhang





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

From
Akshay Joshi
Date:


On Mon, Sep 11, 2017 at 5:34 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, can you review/commit this please?

    Sure Dave. 

Thanks.

On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang <tezhang@pivotal.io> wrote:
Hi Hackers,

Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords.

- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum
- No behavior change to pg and ppas, still use "x-pgsql"

Regards,
Hao Wang & Teng Zhang





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

From
Akshay Joshi
Date:
Code looks good to me. Thanks patch applied.

On Mon, Sep 11, 2017 at 5:40 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Mon, Sep 11, 2017 at 5:34 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, can you review/commit this please?

    Sure Dave. 

Thanks.

On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang <tezhang@pivotal.io> wrote:
Hi Hackers,

Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords.

- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum
- No behavior change to pg and ppas, still use "x-pgsql"

Regards,
Hao Wang & Teng Zhang





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246