Postgres Pro
Downloads
Home   >   mailing lists

Thread: Patch for SonarQube code scan fixes

Patch for SonarQube code scan fixes

From
Nikhil Mohite
Date:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Table file(utils):
  • Refactor this function to reduce its Cognitive Complexity from 39 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 122 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 58 to the 15 allowed.
2. Table init file:
  • Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.


Regards,
Nikhil Mohite.
Attachment

Re: Patch for SonarQube code scan fixes

From
Akshay Joshi
Date:
Thanks, patch applied. I have changed the function name from "def _get_reverse_engineered_sql_for_<node name>" to "def _get_resql_for_<node name>", because function name is too long.

On Mon, Jul 13, 2020 at 9:40 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Table file(utils):
  • Refactor this function to reduce its Cognitive Complexity from 39 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 122 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 58 to the 15 allowed.
2. Table init file:
  • Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.


Regards,
Nikhil Mohite.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246