diff --git a/doc/src/sgml/ref/pg_basebackup.sgml b/doc/src/sgml/ref/pg_basebackup.sgml index eb0c1d6..cad613e 100644 --- a/doc/src/sgml/ref/pg_basebackup.sgml +++ b/doc/src/sgml/ref/pg_basebackup.sgml @@ -203,6 +203,17 @@ PostgreSQL documentation + + + + Specify the location for the transaction log directory. + xlogdir should be an absolute path. + User can specify the xlog directory, only if the format is plain. + + + + + diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index a1e12a8..6daa764 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -35,6 +35,7 @@ /* Global options */ char *basedir = NULL; +static char *xlog_dir = ""; char format = 'p'; /* p(lain)/t(ar) */ char *label = "pg_basebackup base backup"; bool showprogress = false; @@ -115,6 +116,8 @@ usage(void) printf(_(" -x, --xlog include required WAL files in backup (fetch mode)\n")); printf(_(" -X, --xlog-method=fetch|stream\n" " include required WAL files with specified method\n")); + printf(_(" --xlogdir=XLOGDIR location for the transaction log directory\n")); + printf(_(" -z, --gzip compress tar output\n")); printf(_(" -Z, --compress=0-9 compress tar output with given compression level\n")); printf(_("\nGeneral options:\n")); @@ -983,7 +986,8 @@ ReceiveAndUnpackTarFile(PGconn *conn, PGresult *res, int rownum) * by the wal receiver process, so just ignore failure * on that. */ - if (!streamwal || strcmp(filename + strlen(filename) - 8, "/pg_xlog") != 0) + if ((!streamwal && (strcmp(xlog_dir, "") == 0)) + || strcmp(filename + strlen(filename) - 8, "/pg_xlog") != 0) { fprintf(stderr, _("%s: could not create directory \"%s\": %s\n"), @@ -1666,6 +1670,7 @@ main(int argc, char **argv) {"status-interval", required_argument, NULL, 's'}, {"verbose", no_argument, NULL, 'v'}, {"progress", no_argument, NULL, 'P'}, + {"xlogdir", required_argument, NULL, 1}, {NULL, 0, NULL, 0} }; int c; @@ -1750,6 +1755,9 @@ main(int argc, char **argv) exit(1); } break; + case 1: + xlog_dir = pg_strdup(optarg); + break; case 'l': label = pg_strdup(optarg); break; @@ -1862,10 +1870,11 @@ main(int argc, char **argv) exit(1); } - if (format != 'p' && streamwal) + if (format != 'p' && (streamwal ||(strcmp(xlog_dir, "") != 0))) { fprintf(stderr, - _("%s: WAL streaming can only be used in plain mode\n"), + _("%s: WAL streaming or providing user specified xlog directory" + " can only be used in plain mode\n"), progname); fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname); @@ -1890,6 +1899,40 @@ main(int argc, char **argv) if (format == 'p' || strcmp(basedir, "-") != 0) verify_dir_is_empty_or_create(basedir); + /* Create transaction log symlink, if required */ + if (strcmp(xlog_dir, "") != 0) + { + char *linkloc; + + /* clean up xlog directory name, check it's absolute */ + canonicalize_path(xlog_dir); + if (!is_absolute_path(xlog_dir)) + { + fprintf(stderr, _("%s: transaction log directory location must be " + "an absolute path\n"), progname); + exit(1); + } + + verify_dir_is_empty_or_create(xlog_dir); + + /* form name of the place where the symlink must go */ + linkloc = (char *) pg_malloc0(strlen(basedir) + 8 + 1); + sprintf(linkloc, "%s/pg_xlog", basedir); + +#ifdef HAVE_SYMLINK + if (symlink(xlog_dir, linkloc) != 0) + { + fprintf(stderr, _("%s: could not create symbolic link \"%s\": %s\n"), + progname, linkloc, strerror(errno)); + exit(1); + } +#else + fprintf(stderr, _("%s: symlinks are not supported on this platform " + "cannot use xlogdir")); + exit(1); +#endif + } + BaseBackup(); return 0;