From bdc5c5b6d6361a5e5d2de5b5fd749ceb93045aa0 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Fri, 19 Aug 2016 11:57:49 +0900 Subject: [PATCH 1/2] Bundle md5.c into src/common/ --- contrib/passwordcheck/passwordcheck.c | 2 +- src/backend/commands/user.c | 2 +- src/backend/libpq/Makefile | 2 +- src/backend/libpq/auth.c | 2 +- src/backend/libpq/crypt.c | 2 +- src/backend/utils/adt/varlena.c | 2 +- src/common/Makefile | 2 +- src/{backend/libpq => common}/md5.c | 11 +++++++---- src/include/{libpq => common}/md5.h | 2 +- src/interfaces/libpq/Makefile | 9 +++++++-- src/interfaces/libpq/fe-auth.c | 2 +- src/tools/msvc/Mkvcbuild.pm | 2 +- 12 files changed, 24 insertions(+), 16 deletions(-) rename src/{backend/libpq => common}/md5.c (98%) rename src/include/{libpq => common}/md5.h (96%) diff --git a/contrib/passwordcheck/passwordcheck.c b/contrib/passwordcheck/passwordcheck.c index b4c1ce0..b38d1e3 100644 --- a/contrib/passwordcheck/passwordcheck.c +++ b/contrib/passwordcheck/passwordcheck.c @@ -20,9 +20,9 @@ #include #endif +#include "common/md5.h" #include "commands/user.h" #include "fmgr.h" -#include "libpq/md5.h" PG_MODULE_MAGIC; diff --git a/src/backend/commands/user.c b/src/backend/commands/user.c index b6ea950..821dce3 100644 --- a/src/backend/commands/user.c +++ b/src/backend/commands/user.c @@ -29,7 +29,7 @@ #include "commands/dbcommands.h" #include "commands/seclabel.h" #include "commands/user.h" -#include "libpq/md5.h" +#include "common/md5.h" #include "miscadmin.h" #include "storage/lmgr.h" #include "utils/acl.h" diff --git a/src/backend/libpq/Makefile b/src/backend/libpq/Makefile index 09410c4..82d424f 100644 --- a/src/backend/libpq/Makefile +++ b/src/backend/libpq/Makefile @@ -14,7 +14,7 @@ include $(top_builddir)/src/Makefile.global # be-fsstubs is here for historical reasons, probably belongs elsewhere -OBJS = be-fsstubs.o be-secure.o auth.o crypt.o hba.o ip.o md5.o pqcomm.o \ +OBJS = be-fsstubs.o be-secure.o auth.o crypt.o hba.o ip.o pqcomm.o \ pqformat.o pqmq.o pqsignal.o ifeq ($(with_openssl),yes) diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c index fc8b99b..fd4bc4b 100644 --- a/src/backend/libpq/auth.c +++ b/src/backend/libpq/auth.c @@ -21,12 +21,12 @@ #include #include +#include "common/md5.h" #include "libpq/auth.h" #include "libpq/crypt.h" #include "libpq/ip.h" #include "libpq/libpq.h" #include "libpq/pqformat.h" -#include "libpq/md5.h" #include "miscadmin.h" #include "replication/walsender.h" #include "storage/ipc.h" diff --git a/src/backend/libpq/crypt.c b/src/backend/libpq/crypt.c index d79f5a2..d84a180 100644 --- a/src/backend/libpq/crypt.c +++ b/src/backend/libpq/crypt.c @@ -21,8 +21,8 @@ #endif #include "catalog/pg_authid.h" +#include "common/md5.h" #include "libpq/crypt.h" -#include "libpq/md5.h" #include "miscadmin.h" #include "utils/builtins.h" #include "utils/syscache.h" diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c index bf7c0cd..582d3e4 100644 --- a/src/backend/utils/adt/varlena.c +++ b/src/backend/utils/adt/varlena.c @@ -21,8 +21,8 @@ #include "access/tuptoaster.h" #include "catalog/pg_collation.h" #include "catalog/pg_type.h" +#include "common/md5.h" #include "lib/hyperloglog.h" -#include "libpq/md5.h" #include "libpq/pqformat.h" #include "miscadmin.h" #include "parser/scansup.h" diff --git a/src/common/Makefile b/src/common/Makefile index 72b7369..e245867 100644 --- a/src/common/Makefile +++ b/src/common/Makefile @@ -37,7 +37,7 @@ override CPPFLAGS += -DVAL_LDFLAGS_SL="\"$(LDFLAGS_SL)\"" override CPPFLAGS += -DVAL_LIBS="\"$(LIBS)\"" OBJS_COMMON = config_info.o controldata_utils.o exec.o keywords.o \ - pg_lzcompress.o pgfnames.o psprintf.o relpath.o rmtree.o \ + md5.o pg_lzcompress.o pgfnames.o psprintf.o relpath.o rmtree.o \ string.o username.o wait_error.o OBJS_FRONTEND = $(OBJS_COMMON) fe_memutils.o restricted_token.o diff --git a/src/backend/libpq/md5.c b/src/common/md5.c similarity index 98% rename from src/backend/libpq/md5.c rename to src/common/md5.c index 5af54e6..6dad165 100644 --- a/src/backend/libpq/md5.c +++ b/src/common/md5.c @@ -14,13 +14,16 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * src/backend/libpq/md5.c + * src/common/md5.c */ -/* This is intended to be used in both frontend and backend, so use c.h */ -#include "c.h" +#ifndef FRONTEND +#include "postgres.h" +#else +#include "postgres_fe.h" +#endif -#include "libpq/md5.h" +#include "common/md5.h" /* diff --git a/src/include/libpq/md5.h b/src/include/common/md5.h similarity index 96% rename from src/include/libpq/md5.h rename to src/include/common/md5.h index f3eec8b..4a04320 100644 --- a/src/include/libpq/md5.h +++ b/src/include/common/md5.h @@ -9,7 +9,7 @@ * Portions Copyright (c) 1996-2016, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * src/include/libpq/md5.h + * src/include/common/md5.h * *------------------------------------------------------------------------- */ diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile index 0b4065e..f9b1aa9 100644 --- a/src/interfaces/libpq/Makefile +++ b/src/interfaces/libpq/Makefile @@ -40,9 +40,11 @@ OBJS += chklocale.o inet_net_ntop.o noblock.o pgstrcasecmp.o pqsignal.o \ # libpgport C files that are needed if identified by configure OBJS += $(filter crypt.o getaddrinfo.o getpeereid.o inet_aton.o open.o system.o snprintf.o strerror.o strlcpy.o win32error.o win32setlocale.o, $(LIBOBJS)) # backend/libpq -OBJS += ip.o md5.o +OBJS += ip.o # utils/mb OBJS += encnames.o wchar.o +# common +OBJS += md5.o ifeq ($(with_openssl),yes) OBJS += fe-secure-openssl.o @@ -96,7 +98,10 @@ backend_src = $(top_srcdir)/src/backend chklocale.c crypt.c getaddrinfo.c getpeereid.c inet_aton.c inet_net_ntop.c noblock.c open.c system.c pgsleep.c pgstrcasecmp.c pqsignal.c snprintf.c strerror.c strlcpy.c thread.c win32error.c win32setlocale.c: % : $(top_srcdir)/src/port/% rm -f $@ && $(LN_S) $< . -ip.c md5.c: % : $(backend_src)/libpq/% +ip.c: % : $(backend_src)/libpq/% + rm -f $@ && $(LN_S) $< . + +md5.c: % : $(top_srcdir)/src/common/% rm -f $@ && $(LN_S) $< . encnames.c wchar.c: % : $(backend_src)/utils/mb/% diff --git a/src/interfaces/libpq/fe-auth.c b/src/interfaces/libpq/fe-auth.c index d237262..9b233e3 100644 --- a/src/interfaces/libpq/fe-auth.c +++ b/src/interfaces/libpq/fe-auth.c @@ -40,7 +40,7 @@ #include "libpq-fe.h" #include "fe-auth.h" -#include "libpq/md5.h" +#include "common/md5.h" #ifdef ENABLE_GSS diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm index da4d984..4f359d4 100644 --- a/src/tools/msvc/Mkvcbuild.pm +++ b/src/tools/msvc/Mkvcbuild.pm @@ -111,7 +111,7 @@ sub mkvcbuild our @pgcommonallfiles = qw( config_info.c controldata_utils.c exec.c keywords.c - pg_lzcompress.c pgfnames.c psprintf.c relpath.c rmtree.c + md5.c pg_lzcompress.c pgfnames.c psprintf.c relpath.c rmtree.c string.c username.c wait_error.c); our @pgcommonfrontendfiles = ( -- 2.9.3