From f0c0dc3511c66a1e0fe0e4cc7ad2995f5f40bd7c Mon Sep 17 00:00:00 2001 From: Lars Kanis Date: Thu, 17 Oct 2019 19:37:51 +0200 Subject: [PATCH] Fix wrong connection status on invalid "connect_timeout" Commit e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb introduced stricter checks for integer values in connection parameters. However in case of "connect_timeout" such invalid integer values leaded to a connection status other than CONNECTION_OK or CONNECTION_BAD. This patch explicit sets CONNECTION_BAD. Signed-off-by: Lars Kanis --- src/interfaces/libpq/fe-connect.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index f91f0f2..44d927e 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -2008,7 +2008,11 @@ connectDBComplete(PGconn *conn) { if (!parse_int_param(conn->connect_timeout, &timeout, conn, "connect_timeout")) + { + /* invalid integer */ + conn->status = CONNECTION_BAD; return 0; + } if (timeout > 0) { -- 2.17.1