From 886e241e304a23bb31b5e59f12149741dfff2b14 Mon Sep 17 00:00:00 2001 From: Ashutosh Bapat Date: Tue, 25 Feb 2025 11:42:51 +0530 Subject: [PATCH 2/2] Do not dump statistics in the file dumped for comparison The dumped and restored statistics of a materialized view may differ as reported in [1]. Hence do not dump the statistics to avoid differences in the dump output from the original and restored database. [1] https://www.postgresql.org/message-id/CAExHW5s47kmubpbbRJzSM-Zfe0Tj2O3GBagB7YAyE8rQ-V24Uw@mail.gmail.com Ashutosh Bapat --- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/bin/pg_upgrade/t/002_pg_upgrade.pl b/src/bin/pg_upgrade/t/002_pg_upgrade.pl index d08eea6693f..f931fef2307 100644 --- a/src/bin/pg_upgrade/t/002_pg_upgrade.pl +++ b/src/bin/pg_upgrade/t/002_pg_upgrade.pl @@ -656,15 +656,15 @@ sub get_dump_for_comparison my $dumpfile = $tempdir . '/' . $file_prefix . '.sql'; my $dump_adjusted = "${dumpfile}_adjusted"; - # Usually we avoid comparing statistics in our tests since it is flaky by - # nature. However, if statistics is dumped and restored it is expected to be - # restored as it is i.e. the statistics from the original database and that - # from the restored database should match. We turn off autovacuum on the - # source and the target database to avoid any statistics update during - # restore operation. Hence we do not exclude statistics from dump. + # If statistics is dumped and restored it is expected to be restored as it + # is i.e. the statistics from the original database and that from the + # restored database should match. We turn off autovacuum on the source and + # the target database to avoid any statistics update during restore + # operation. But as of now, there are cases when statistics is not being + # restored faithfully. Hence for now do not dump statistics. $node->command_ok( [ - 'pg_dump', '--no-sync', '-d', $node->connstr($db), '-f', + 'pg_dump', '--no-sync', '--no-statistics', '-d', $node->connstr($db), '-f', $dumpfile ], 'dump for comparison succeeded'); -- 2.34.1