On 16/09/2025 21:13, Sami Imseih wrote:
They can be committed together if there is agreement that tests are worth it.
One argument for keeping the tests would be that they nicely bring together the side-effect (logging) and these use-cases, whereas in the code they're pretty distant, making the connection not obvious.
For example, they will come in handy when simplifying CreatePortal in a separate patch as discussed.
Kind regards,
Mircea Cadariu