Re: pg_createsubscriber TAP test wrapping makes command options hard to read. - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date
Msg-id 0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com
Whole thread Raw
In response to Re: pg_createsubscriber TAP test wrapping makes command options hard to read.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
List pgsql-hackers
On Mon, Jan 20, 2025, at 7:49 PM, Tom Lane wrote:
"Euler Taveira" <euler@eulerto.com> writes:
> It is kind of annoying to keep version 20230309 around to run perltidy. Do we
> have any other alternatives?

As it says in src/tools/pgindent/README:

2) Install perltidy.  Please be sure it is version 20230309 (older and newer
   versions make different formatting choices, and we want consistency).

I don't think anyone is especially wedded to 20230309 in particular,
but we don't want different developers using different versions and
coming out with different results.  The whole point of this effort
is to standardize code layout as best we can, so that would be
counterproductive.

I can live with that.

Do you have a strong argument for switching to some other specific
version of perltidy?


I don't. Let's see if the Dagfinn's patch will maintain more stable formatting
over the years. I tested in a previous version (20220613) after applying the
patch and it didn't suggest changes.


--
Euler Taveira

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Statistics Import and Export
Next
From: Peter Smith
Date:
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.