Sigh: 7.0 pg_dump fails if user table has index on OID - Mailing list pgsql-hackers

If any user-created index is on a system column (eg, OID),
7.0 pg_dump fails with "parseNumericArray: bogus number".

Mea culpa, mea maxima culpa --- some well-intentioned error checking
code was a bit too tight.  (But how'd this get through beta with no
one noticing?  It's been broken since January...)

The attached patch is committed for 7.0.1, but you will need to apply
it by hand if you have such indexes and you want to make a dump before
7.0.1 comes out.  (Alternatively, drop the indexes and remake them
by hand later.)

Thanks to Kyle Bateman for the bug report.
        regards, tom lane

*** src/bin/pg_dump/common.c.orig    Wed Apr 12 13:16:14 2000
--- src/bin/pg_dump/common.c    Fri May 19 19:00:00 2000
***************
*** 190,196 ****         }         else         {
!             if (!isdigit(s) || j >= sizeof(temp) - 1)             {                 fprintf(stderr,
"parseNumericArray:bogus number\n");                 exit(2);
 
--- 190,196 ----         }         else         {
!             if (!(isdigit(s) || s == '-') || j >= sizeof(temp) - 1)             {                 fprintf(stderr,
"parseNumericArray:bogus number\n");                 exit(2);