Re: Memory Accounting - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Memory Accounting
Date
Msg-id 10470.1570215529@sss.pgh.pa.us
Whole thread Raw
In response to Re: Memory Accounting  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes:
> On Fri, Oct 4, 2019 at 7:32 AM Jeff Davis <pgsql@j-davis.com> wrote:
>> The patch has been floating around for a very long time, so I don't
>> remember exactly why I chose a signed value. Sorry.

> I am reminded of the fact that int64 is used to size buffers within
> tuplesort.c, because it needs to support negative availMem sizes --
> when huge allocations were first supported, tuplesort.c briefly used
> "Size", which didn't work. Perhaps it had something to do with that.

I wonder if we should make that use ssize_t instead.  Probably
not worth the trouble.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Memory Accounting
Next
From: Tom Lane
Date:
Subject: Re: Problem with repalloc downsizing patch