Re: Transform for pl/perl - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Transform for pl/perl
Date
Msg-id 10510.1525026483@sss.pgh.pa.us
Whole thread Raw
In response to Re: Transform for pl/perl  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: Transform for pl/perl
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 4/24/18 14:31, Andrew Dunstan wrote:
>> There is the routine IsValidJsonNumber that helps - see among others
>> hstore_io.c for an example use.

> I would need something like that taking a double/float8 input.  But I
> think there is no such shortcut available, so I just wrote out the tests
> for isinf and isnan explicitly.  Attached patch should fix it.
> jsonb_plpython will need a similar fix.

I looked this over, it looks fine to me.  I first questioned the use
of ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE for rejecting NaN, but I see
that we are doing that in lots of comparable places (e.g., dtoi4())
so I'm on board with it.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Joe Wildish
Date:
Subject: Re: Implementing SQL ASSERTION
Next
From: David Fetter
Date:
Subject: Re: Implementing SQL ASSERTION