Re: [PATCH 04/16] Add embedded list interface (header only) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH 04/16] Add embedded list interface (header only)
Date
Msg-id 11221.1340376080@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH 04/16] Add embedded list interface (header only)  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: [PATCH 04/16] Add embedded list interface (header only)
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> Oh, I and Peter weren't talking about the pg_list.h stuff, it was about my 
> 'embedded list' implementation which started this subthread. The 
> pg_list.h/list.c stuff isn't problematic as far as I have seen in profiles; 
> its checks are pretty simple so I do not find that surprising. We might want 
> to disable it by default anyway.

> In my code the list checking stuff iterates over the complete list after 
> modifications and checks that all prev/next pointers are correct so its linear 
> in itself...

Well, so does list.c, so I'd expect the performance risks to be similar.
Possibly you're testing on longer lists than are typical in the backend.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [PATCH 01/16] Overhaul walsender wakeup handling
Next
From: Andres Freund
Date:
Subject: Re: [PATCH 01/16] Overhaul walsender wakeup handling