Re: [PATCH v5] Show detailed table persistence in \dt+ - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH v5] Show detailed table persistence in \dt+
Date
Msg-id 11253.1562098587@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH v5] Show detailed table persistence in \dt+  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH v5] Show detailed table persistence in \dt+
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-Jul-02, Tom Lane wrote:
>> * The persistence description values ought to be translatable, as
>> is the usual practice in describe.c.  This is slightly painful
>> because it requires tweaking the translate_columns[] values in a
>> non-constant way, but it's not that bad.

> LGTM.  I only fear that the cols_so_far thing is easy to break, and the
> breakage will be easy to miss.

Yeah, but that's pretty true of all the translatability stuff in
describe.c.  I wonder if there's any way to set up tests for that.
The fact that the .po files lag so far behind the source code seems
like an impediment --- even if we made a test case that presumed
--enable-nls and tried to exercise this, the lack of translations
for the new words would get in the way for a long while.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH v4] Add \warn to psql
Next
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH v5] Show detailed table persistence in \dt+