Re: pg_dump dumps event triggers and transforms unconditionally - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump dumps event triggers and transforms unconditionally
Date
Msg-id 12189.1452636810@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump dumps event triggers and transforms unconditionally  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> AFAICT event triggers don't belong to any particular schema, so I'd
>> propose that they be dumped only when include_everything is true,
>> which is the usual rule for objects that don't belong to any schema.
>> 
>> Transforms have got the same issue, which means that the dump of a
>> database containing, eg, hstore_plperl is outright broken: it will
>> dump both the extension *and* a CREATE TRANSFORM command.  Again, they
>> ought to obey the default rules for schema-less objects, which in
>> this case is "dump if include_everything and not an extension member".

> Sounds reasonable.  (I assume this last detailed rule is what applies to
> both object types.  Surely event triggers can be part of an extension
> too.)

Don't know offhand if they can or not, but the code will do the right
thing if so.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Adam Brightwell
Date:
Subject: Re: bootstrap pg_shseclabel in relcache initialization
Next
From: Tom Lane
Date:
Subject: Re: WIP: Rework access method interface