Re: [ADMIN] recovery is stuck when children are not processing SIGQUIT from previous crash - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [ADMIN] recovery is stuck when children are not processing SIGQUIT from previous crash
Date
Msg-id 1274.1260368927@sss.pgh.pa.us
Whole thread Raw
In response to Re: [ADMIN] recovery is stuck when children are not processing SIGQUIT from previous crash  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [ADMIN] recovery is stuck when children are not processing SIGQUIT from previous crash
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> Yeah, on reflection, calling elog in the SIGQUIT handler is just waiting
> for trouble.  The call could block for any number of reasons, because
> there is a boatload of functionality that comes with a logging call.  In
> the overall scheme of things, you don't really lose much if you just
> delete the call altogether, because in the event that it's called the
> postmaster will already have logged that it is going to kill all
> children.  Or there ought to be some kind of alarm that would abort the
> thing if it takes too long.

Well, the point of that call is not to log the event. The point is to
tell the client why it's losing its connection.  Admittedly there are
assorted corner cases where that would fail, but it works well enough
often enough that I don't want to just delete the attempt.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Zdenek Kotala
Date:
Subject: Re: [patch] pg_ctl init extension
Next
From: Tom Lane
Date:
Subject: Re: XLogInsert