Re: [HACKERS] I can't compile cvs snapshot ... - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] I can't compile cvs snapshot ...
Date
Msg-id 12764.927726948@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] I can't compile cvs snapshot ...  (Bruce Momjian <maillist@candle.pha.pa.us>)
Responses Re: [HACKERS] I can't compile cvs snapshot ...
Re: [HACKERS] I can't compile cvs snapshot ...
List pgsql-hackers
Bruce Momjian <maillist@candle.pha.pa.us> writes:
>> Does this mean we are not allowed to use "U"? I think this is leagal
>> according to the standard C grammer.

> Well, it seems BSD indent mucks up 0x7fU, so I would prefer if we didn't
> use it.

If pgindent mucks up standard C constructs then pgindent is broken.

This is not open to debate --- if you are going to run our entire
source base through pgindent just a few days before every release,
then the tool has to be something we can have 100 percent, no-questions-
asked confidence in.  Telling people to obey weird little coding
conventions is no answer.  (If everyone reliably did that, we'd not
need pgindent in the first place.)

It appears that BSD indent doesn't have a problem with 0xnnnL, so
teaching it about 0xnnnU can't be that hard if you have the source.
(I don't...)

Maybe it is time to take another look at GNU indent?
        regards, tom lane


pgsql-hackers by date:

Previous
From: wieck@debis.com (Jan Wieck)
Date:
Subject: Re: [HACKERS] Help: fmgr_info: function 0: cache lookup failed
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] I can't compile cvs snapshot ...