Re: pg_basebackup wish list - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_basebackup wish list
Date
Msg-id 12873.1473708697@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_basebackup wish list  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: pg_basebackup wish list
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 8/19/16 1:04 AM, Masahiko Sawada wrote:
>> I agree with adding this as an option and removing directory by default.
>> And it looks good to me except for missing new line in usage output.
>> 
>> printf(_("  -l, --label=LABEL      set backup label\n"));
>> +       printf(_("  -n, --noclean          do not clean up after errors"));
>> printf(_("  -P, --progress         show progress information\n"));

> Committed with that fix.  Thanks.

Hm, there was just a kerfuffle about spelling things like this
"--no-clean" etc.  I wasn't on board with removing existing spellings,
but surely all newly added switches should use the "no-" spelling?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pg_basebackup wish list
Next
From: Mark Dilger
Date:
Subject: inappropriate use of NameGetDatum macro