Re: Removal of useless include references - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Removal of useless include references
Date
Msg-id 1314397545-sup-8387@alvh.no-ip.org
Whole thread Raw
In response to Removal of useless include references  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Removal of useless include references
List pgsql-hackers
Excerpts from Bruce Momjian's message of vie ago 26 01:35:45 -0300 2011:
> It has been years since I ran src/tools/pginclude/pgrminclude to remove
> unnecessary include files.  (I have already fixed things so include
> files can be compiled on their own.)
> 
> The attached patch removes unneeded include references, and marks some
> includes as needing to be skipped by pgrminclude.

In btree_gist I think you should remove #include "postgres.h" from the
.h file and put it in the .c files instead, as is customary.  I think
that would make the other changes incorrect.  ltree.h and pg_upgrade.h
also get this wrong.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pg_restore --no-post-data and --post-data-only
Next
From: Tom Lane
Date:
Subject: Re: Cryptic error message in low-memory conditions