Re: Patch to implement pg_current_logfile() function - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch to implement pg_current_logfile() function
Date
Msg-id 1315.1457623607@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch to implement pg_current_logfile() function  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Patch to implement pg_current_logfile() function
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Mar 9, 2016 at 12:32 PM, Gilles Darold <gilles.darold@dalibo.com> wrote:
>> I choose to allow the log collector to write his current log file name
>> into the lock file 'postmaster.pid'.

> Gosh, why?  Piggybacking this on a file written for a specific purpose
> by a different process seems like making life very hard for yourself,
> and almost certainly a recipe for bugs.

That's a *complete* nonstarter.  postmaster.pid has to be written by the
postmaster process and nobody else.

It's a particularly bad choice for the syslogger, which will exist
fractionally longer than the postmaster, and thus might be trying to write
into the file after the postmaster has removed it.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: Reworks of CustomScan serialization/deserialization
Next
From: Simon Riggs
Date:
Subject: Re: Add generate_series(date,date) and generate_series(date,date,integer)