Re: Fix for win32 stat() problems - Mailing list pgsql-patches

From Tom Lane
Subject Re: Fix for win32 stat() problems
Date
Msg-id 1335.1207838475@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix for win32 stat() problems  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Fix for win32 stat() problems
List pgsql-patches
Magnus Hagander <magnus@hagander.net> writes:
> A whole lot simpler patch :-)

Seems like you no longer need the !defined(_DIRMOD_C) bit here?
Also please include a comment about why <sys/stat.h> has to be
forcibly included.

A more general question: can't we get rid of most of the #ifdef WIN32
cruft in include/port.h, and put it in include/port/win32.h instead?
Seems cleaner that way, at least for things where there's just an
#ifdef WIN32 hunk and not two cases for Win and not-Win.

            regards, tom lane

pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Fix for win32 stat() problems
Next
From: Tom Lane
Date:
Subject: Re: Fix for win32 stat() problems