Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code - Mailing list pgsql-hackers

From Alexey Vasiliev
Subject Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
Date
Msg-id 1419619333.778631968@f256.i.mail.ru
Whole thread Raw
In response to Re: Re[3]: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
List pgsql-hackers
Thanks for suggestions.

Patch updated.


Mon, 22 Dec 2014 12:07:06 +0900 от Michael Paquier <michael.paquier@gmail.com>:
On Tue, Nov 4, 2014 at 6:25 AM, Alexey Vasiliev <leopard_ne@inbox.ru> wrote:
> Added new patch.
Seems useful to me to be able to tune this interval of time.

I would simply reword the documentation as follows:
If <varname>restore_command</> returns nonzero exit status code, retry
command after the interval of time specified by this parameter.
Default value is <literal>5s</>.

Also, I think that it would be a good idea to error out if this
parameter has a value of let's say, less than 1s instead of doing a
check for a positive value in the waiting latch. On top of that, the
default value of restore_command_retry_interval should be 5000 and not
0 to simplify the code.
--
Michael


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


--
Alexey Vasiliev
Attachment

pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: BUG #12330: ACID is broken for unique constraints
Next
From: Bruce Momjian
Date:
Subject: Re: What exactly is our CRC algorithm?