Re: pgsql: Integrate recovery.conf into postgresql.conf - Mailing list pgsql-hackers

From Sergei Kornilov
Subject Re: pgsql: Integrate recovery.conf into postgresql.conf
Date
Msg-id 145311543257278@sas1-0a6c2e2b59d7.qloud-c.yandex.net
Whole thread Raw
In response to Re: pgsql: Integrate recovery.conf into postgresql.conf  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pgsql: Integrate recovery.conf into postgresql.conf
List pgsql-hackers
Hello

> I think I would have done 'if (targetSettingsCount != 1)' here.
Streaming replication does not have any recovery_target.
Well, i can check StandbyModeRequested too and allow 0 recovery_target only for standby mode.

>>  -# Multiple targets
>>  -# Last entry has priority (note that an array respects the order of items
>>  -# not hashes).
>
> You could (and imv should) include a test that throws an expected error
> if multiple targets are specified.
We have some example for checking unable-to-start DB? Did not find yet

> Let’s at least fix the currently committed patch before adding new features or changing how things in recovery work.
+1

regards, Sergei


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Integrate recovery.conf into postgresql.conf
Next
From: Petr Jelinek
Date:
Subject: Re: Copy function for logical replication slots