Re: pgsql: Increase the number of possible random seeds per time period. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Increase the number of possible random seeds per time period.
Date
Msg-id 14712.1542253115@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Increase the number of possible random seeds per time period.  (Thomas Munro <tmunro@postgresql.org>)
Responses Re: pgsql: Increase the number of possible random seeds per time period.
List pgsql-committers
Thomas Munro <tmunro@postgresql.org> writes:
> Increase the number of possible random seeds per time period.

Um, this bit is *not* right:

+           ((unsigned int) MyStartTimestamp >> 20));

You're cutting it down to 32 bits and then right shifting, which
means you are shifting in a lot of zeroes when you could be shifting
in something that's not quite as predetermined.  I had in mind to do
the shifts in uint64 arithmetic and then narrow the final XOR result
to int (maybe let the compiler do that implicitly).

            regards, tom lane


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Increase the number of possible random seeds per time period.
Next
From: Thomas Munro
Date:
Subject: Re: pgsql: Increase the number of possible random seeds per time period.