Re: DatabaseMetaData patch - Mailing list pgsql-patches

From Rene Pijlman
Subject Re: DatabaseMetaData patch
Date
Msg-id 152rnt0k33g1m6t70eflr5uvpnip0ubp49@4ax.com
Whole thread Raw
In response to DatabaseMetaData patch  (Liam Stewart <liams@redhat.com>)
Responses Re: DatabaseMetaData patch
List pgsql-patches
On Fri, 17 Aug 2001 15:59:38 -0400, you wrote:
>Here is a small patch for the DatabaseMetaData class (both jdbc1 and
>jdbc2) that gets the unimplemented methods that should return a
>ResultSet to throw an SQLException -- correct according the JDBC API.
>They used to return null.

Looks good. Fix in 7.2 documented on
http://lab.applinet.nl/postgresql-jdbc/#DatabaseMetaData (work
in progress).

>Also the getTypeInfo method will throw an
>SQLException if the ExecSQL call returns null.

Shouldn't

   throw new PSQLException("metadata unavailable");

in getTypeInfo() be something like:

   throw new PSQLException("postgresql.meta.unavailable");

to allow translation of the error message in the
errors*.properties files?

Regards,
René Pijlman

pgsql-patches by date:

Previous
From: "John Gray"
Date:
Subject: New version of XML support routines (0.2)
Next
From: Bruce Momjian
Date:
Subject: Re: Revised Patch to allow multiple table locks in "Unison"