Re: Make pg_stat_io view count IOs as bytes instead of blocks - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Make pg_stat_io view count IOs as bytes instead of blocks
Date
Msg-id 1541695.1737002054@sss.pgh.pa.us
Whole thread Raw
In response to Re: Make pg_stat_io view count IOs as bytes instead of blocks  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> I cannot reproduce that, perhaps I'm just missing something with these
> switches.  Do you think that a cast would cool things?  Please see the
> attached for the idea.

There are only three animals showing this warning (ayu, batfish,
demoiselle) so it likely requires particular clang versions
as well as the right -W switches.

Maybe a cast would silence it, but your draft seems
underparenthesized.  (Which raises the question of whether we
should be using a macro for this at all --- probably there's
not much risk of double-evaluation being a problem, but a
static inline would remove the risk.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: TOAST versus toast
Next
From: Zhang Mingli
Date:
Subject: Inquiry About Determining Parallel Plans for REFRESH MATERIALIZED VIEW