Re: Patch: add conversion from pg_wchar to multibyte - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch: add conversion from pg_wchar to multibyte
Date
Msg-id 15520.1341352186@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch: add conversion from pg_wchar to multibyte  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
Alexander Korotkov <aekorotkov@gmail.com> writes:
> It's likely we also need to assign some names to all these numbers
> (0xf0, 0xf4, 0xfe, 0x9c, 0x9d). But it's hard for me to invent such names.

The encoding ID byte values already have names (see pg_wchar.h), but the
private prefix bytes don't.  I griped about that upthread.  I agree this
code needs some basic readability cleanup that's independent of your
feature addition.  It'd likely be reasonable to do that as a separate
patch.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Incorrect behaviour when using a GiST index on points
Next
From: Tatsuo Ishii
Date:
Subject: Re: Patch: add conversion from pg_wchar to multibyte