Re: AW: Re: GiST for 7.1 !! - Mailing list pgsql-hackers

From Tom Lane
Subject Re: AW: Re: GiST for 7.1 !!
Date
Msg-id 15632.979311776@sss.pgh.pa.us
Whole thread Raw
In response to Re: AW: Re: GiST for 7.1 !!  (Oleg Bartunov <oleg@sai.msu.su>)
Responses Beta4 for GiST? (Was: Re: AW: Re: GiST for 7.1 !! )
Re: AW: Re: GiST for 7.1 !!
List pgsql-hackers
Oleg Bartunov <oleg@sai.msu.su> writes:
> What's wrong with
> warning message if GiST test not passed ?

You're being *way* too optimistic.  An output discrepancy in a test of
GIST we could live with.  But think about other scenarios:

1. GIST test coredumps on some platforms.  This corrupts other tests
(at least through the "system is starting up" failure mode), thus
masking problems that we actually care about.

2. GIST test code does not compile on some platforms, causing "make check"
to fail completely.

At this point my vote is to leave the GIST test in contrib for 7.1.
Anyone who actually cares about GIST (to be blunt: all three of you)
can run it as a separate step.  I don't want it in the standard regress
tests until 7.2, when we will have a reasonable amount of time to test
and debug the test.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Thomas Lockhart
Date:
Subject: Re: AW: Re: tinterval - operator problems on AIX
Next
From: Thomas Lockhart
Date:
Subject: Re: AW: Re: GiST for 7.1 !!