ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> What happens
>> when we add some field or other to those structs?
> There are problems when we modify the middle fields in those
> structs, but it means modification of existing arguments in
> DefineCustomXXXVariable(); The same problems occur in both
> implementations.
No, they are not the same problems. You can rely on the C compiler
to complain if you aren't passing enough arguments to a function.
You can't rely on it to complain if your struct constant is putting
values into the wrong fields.
Perhaps more to the point, guc_tables.h is a file that we don't even
want the majority of the backend including. Why would we think it's
a good idea to make that part of the public API to external modules?
regards, tom lane
