Re: Timeline issue if StartupXLOG() is interrupted right before end-of-recovery record is done - Mailing list pgsql-hackers

From Roman Eskin
Subject Re: Timeline issue if StartupXLOG() is interrupted right before end-of-recovery record is done
Date
Msg-id 15fc1d1c-f0c2-4489-9611-b0262c14cfdc@arenadata.io
Whole thread Raw
In response to Re: Timeline issue if StartupXLOG() is interrupted right before end-of-recovery record is done  ("Andrey M. Borodin" <x4mmm@yandex-team.ru>)
List pgsql-hackers
Hi Andrey,

Thank you for your feedback!

> I think here you can just specify target timeline for the standby instance_1 and it will continue recovery from
instance_2.

Most likely yes, but nevertheless it looks more like a W/A.

> Persisting recovery signal file for some _timeout_ seems super dangerous to me. In distributed systems every extra
_timeout_is a source of complexity, uncertainty and despair.
 

The approach is not about persisting the signal files for some timeout. 
Currently the files are removed in StartupXLOG() before 
writeTimeLineHistory() and PerformRecoveryXLogAction() are called. The 
suggestion is to move the file removal after PerformRecoveryXLogAction() 
inside StartupXLOG().

Best regards,
Roman Eskin





pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Replace current implementations in crypt() and gen_salt() to OpenSSL
Next
From: Marcos Pegoraro
Date:
Subject: Year of first commit