Re: pg_archivecleanup debug message consistency - Mailing list pgsql-hackers

"Erik Rijkers" <er@xs4all.nl> writes:
> If only for consistency, this patch adds the path info to that message.

Seems reasonable, but speaking of consistency:

> +#ifdef WIN32
> +                snprintf(WALFilePath, MAXPGPATH, "%s\\%s", archiveLocation, exclusiveCleanupFileName);
> +#else
> +                snprintf(WALFilePath, MAXPGPATH, "%s/%s", archiveLocation, exclusiveCleanupFileName);
> +#endif

I see that you copied-and-pasted this pattern from somewhere else in
pg_archivecleanup.c, but I'd like to argue that it's out of place there
too.  We don't go out of our way to show Windows paths with backslashes
anywhere in the core code, so why is pg_archivecleanup doing it?  I
think we should just drop the ifdef and do %s/%s always.
        regards, tom lane