Re: [pgsql-hackers-win32] snprintf causes regression - Mailing list pgsql-hackers

From pgsql@mohawksoft.com
Subject Re: [pgsql-hackers-win32] snprintf causes regression
Date
Msg-id 16655.24.91.171.78.1110560549.squirrel@mail.mohawksoft.com
Whole thread Raw
In response to Re: [pgsql-hackers-win32] snprintf causes regression tests  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [pgsql-hackers-win32] snprintf causes regression
List pgsql-hackers
> Tom Lane wrote:
>> pgsql@mohawksoft.com writes:
>> >>> Please see my posting about using a macro for snprintf.
>>
>> > Wasn't the issue about odd behavior of the Win32 linker choosing the
>> wrong
>> > vnsprintf?
>>
>> You're right, the point about the macro was to avoid linker weirdness on
>> Windows.  We need to do that part in any case.  I think Bruce confused
>> that issue with the one about whether our version supported %n$
>> adequately ... which it doesn't just yet ...
>
> Perhaps I am reading old email in this reply but I thought I should
> clarify:
>
> Once we do:
>
>     #define vsnprintf(...)        pg_vsnprintf(__VA_ARGS__)
>     #define snprintf(...)         pg_snprintf(__VA_ARGS__)
>     #define printf(...)           pg_printf(__VA_ARGS__)


I'm not sure that macros can have variable number of arguments on all
supported platforms. I've been burnt by this before.


pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: PostgreSQL pam ldap document
Next
From: Alvaro Herrera
Date:
Subject: Re: TODO item: support triggers on columns