On Mon, Sep 15, 2025 at 4:23 AM, David Rowley <dgrowleyml@gmail.com> wrote:
> For the v2 patch, I've hacked on that a bit and stripped out the
> trss_boundsInitialized stuff and just make it so we recalculate the
> TID List/Range on every recheck. I also added another isolation test
> permutation to have s1 rollback and ensure that s2 updates the ctid =
> '(0,1)' tuple.
Thanks, this seems sensible given the reality that rescan happens once per tuple. The `if (node->tss_TidList == NULL)`
checkyou kept from me seems likewise pointless in v3-0001 but not particularly intrusive (though of course you use it
inv3-0002).
Otherwise v3-0001 lgtm. (I also took a look at v3-0002 and don't see any immediate issues, though neither would I
reallyconsider myself qualified to review it.)
Sophie
