Re: [Proposal] Allow pg_dump to include all child tables with the root table - Mailing list pgsql-hackers

From Cary Huang
Subject Re: [Proposal] Allow pg_dump to include all child tables with the root table
Date
Msg-id 167727895770.12579.12160318039902297475.pgcf@coridan.postgresql.org
Whole thread Raw
In response to [Proposal] Allow pg_dump to include all child tables with the root table  (Gilles Darold <gilles@migops.com>)
Responses Re: [Proposal] Allow pg_dump to include all child tables with the root table
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Hi

the patch applies fine on current master branch and it works as described. However, I would suggest changing the new
optionname from "--with-childs" to "--with-partitions" for several reasons. 
 

"childs" is grammatically incorrect and in the PG community, the term "partitioned table" is normally used to denote a
parenttable, and the term "partition" is used to denote the child table under the parent table. We should use these
termsto stay consistent with the community.
 

Also, I would rephrase the documentation as:

Used in conjunction with <option>-t</option>/<option>--table</option> or
<option>-T</option>/<option>--exclude-table</option>options to include or exclude partitions of the specified tables if
any.

thank you

Cary Huang
================
HighGo Software Canada
www.highgo.ca

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: verbose mode for pg_input_error_message?
Next
From: Stephen Frost
Date:
Subject: Re: Disable rdns for Kerberos tests