Re: [PATCH] random_normal function - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] random_normal function
Date
Msg-id 1682143.1672713508@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] random_normal function  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] random_normal function
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> FYI, here is the failure:
> [21:23:10.814] In file included from pg_prng.c:27:
> [21:23:10.814] ../../src/include/utils/float.h:46:16: error: ‘struct
> Node’ declared inside parameter list will not be visible outside of
> this definition or declaration [-Werror] 
> [21:23:10.814]    46 |         struct Node *escontext);

Hmm ... this looks an awful lot like it is the fault of ccff2d20e
not of the random_normal patch; that is, we probably need a
"struct Node" stub declaration in float.h.  However, why are we
not seeing any reports of this from elsewhere?  I'm concerned now
that there are more places also needing stub declarations, but
my test process didn't expose it.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: New strategies for freezing, advancing relfrozenxid early
Next
From: vignesh C
Date:
Subject: Re: CFM for 2023-01