Re: quiet inline configure check misses a step for clang - Mailing list pgsql-hackers

From Tom Lane
Subject Re: quiet inline configure check misses a step for clang
Date
Msg-id 17506.1396534533@sss.pgh.pa.us
Whole thread Raw
In response to Re: quiet inline configure check misses a step for clang  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: quiet inline configure check misses a step for clang
List pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
> On 2014-04-03 09:43:20 -0400, Tom Lane wrote:
>> I object to the latter; you're proposing to greatly increase the warning
>> noise seen with any compiler that issues a warning for this without caring
>> about .h vs .c.  For somebody who finds gcc -pedantic unusable, I would
>> think you'd have a bit more sympathy for people using other compilers.

> Yea, but which compilers are that? The only one in the buildfarm I could
> find a couple weeks back was acc, and there's a flag we could add to the
> relevant template that silences it. I also don't think that very old
> platforms won't usually be used for active development, so a louder
> build there doesn't really have the same impact as noisy builds for
> actively developed on platforms.

Didn't we already have this discussion last year?  The main points
are all mentioned in

http://www.postgresql.org/message-id/CA+TgmoYJnc4B+8y01gRnAL52GTPbzc3ZsC4SdNW4LGxHqT3Bgg@mail.gmail.com
        regards, tom lane



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: WAL format and API changes (9.5)
Next
From: Andres Freund
Date:
Subject: Re: quiet inline configure check misses a step for clang