Request a Demo
Home   >   mailing lists

Re: vacuumdb --analyze-only does not need to issue VACUUM (ONLY_DATABASE_STATS) ? - Mailing list pgsql-hackers

From Mircea Cadariu
Subject Re: vacuumdb --analyze-only does not need to issue VACUUM (ONLY_DATABASE_STATS) ?
Date
Msg-id 175802794504.1038.6545080940694370040.pgcf@coridan.postgresql.org
Whole thread Raw
In response to vacuumdb --analyze-only does not need to issue VACUUM (ONLY_DATABASE_STATS) ?  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: vacuumdb --analyze-only does not need to issue VACUUM (ONLY_DATABASE_STATS) ?
List pgsql-hackers
Tree view 
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi, 

I tested the patch with log_statement = 'all' and I confirm I do not see the VACUUM log line anymore. 

You could consider adding the following representative test in src/bin/scripts/t/100_vacuumdb.pl: 
$node->issues_sql_unlike(
    [ 'vacuumdb', '--analyze-only', 'postgres' ],
    qr/statement: VACUUM.*;/,
    'vacuumdb --analyze-only skips vacuum');

Kind regards,
Mircea Cadariu

The new status of this patch is: Waiting on Author

pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: Incorrect result of bitmap heap scan.
Next
From: torikoshia
Date:
Subject: Re: RFC: Logging plan of the running query