Re: A little COPY speedup - Mailing list pgsql-patches

From Tom Lane
Subject Re: A little COPY speedup
Date
Msg-id 17692.1172788541@sss.pgh.pa.us
Whole thread Raw
In response to Re: A little COPY speedup  (Heikki Linnakangas <heikki@enterprisedb.com>)
Responses Re: A little COPY speedup
List pgsql-patches
Heikki Linnakangas <heikki@enterprisedb.com> writes:
>> I'll post a patch along those lines.

> Here it is.

> I'm not fond of the macro names for the flag, but couldn't think of
> anything shorter yet descriptive.

Let's reverse the sense of the flag bit; this seems a good idea since
the initial state should be 0 = there are no free pointers.  Also I'd
go with PD_ as the prefix, for consistency with the field names.
This brings us to PD_HAS_FREE_LINE_POINTERS or some abbreviation thereof
(maybe PD_HAS_FREE_LINES is sufficient).

I'd also go with "pd_flags" as the field name; "amprivate" seems to
imply way too much about what we might later use the flags for.

Barring objections, I'll tweak this as above and apply.

            regards, tom lane

pgsql-patches by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: A little COPY speedup
Next
From: "FAST PostgreSQL"
Date:
Subject: Re: WIP Patch - Updateable Cursors