Request a Demo
Home   >   mailing lists

Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache - Mailing list pgsql-hackers

From 邱宇航
Subject Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache
Date
Msg-id 188562F6-5BBB-49AB-B9E1-6312AE7970E8@gmail.com
Whole thread Raw
In response to Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Responses Re: Add pg_buffercache_mark_dirty[_all] functions to the pg_buffercache
List pgsql-hackers
Tree view 
> I do not think that will be a problem but I can change it if the
> general consensus is towards this way. Also, if we change this for
> pg_buffercache_mark_dirty_* functions, I think we need to apply the
> same for the pg_buffercache_evict_* functions.

After some testing, bgwriter/checkpointer didn' blocks the mark buffer
dirty SQL. it's ok to use LWLockAcquire.

There is an extra line break after elog(ERROR, "bad buffer ID: %d", buf)
which can be removed.

Best regards,
Yuhang Qiu

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Next
From: Thomas Munro
Date:
Subject: Re: Consistently use palloc_object() and palloc_array()