Re: pgsql: Fix BRIN to use SnapshotAny during summarization - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix BRIN to use SnapshotAny during summarization
Date
Msg-id 19440.1438917759@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix BRIN to use SnapshotAny during summarization  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
... btw, I believe the reason for the failure here:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jaguarundi&dt=2015-08-06%2011%3A52%3A17

is that brin_page_items() is unsafe.  It's accessing
state->bdesc->bd_tupdesc, which is pointing at the tupdesc of an index
Relation that it no longer has open; not only directly, but via
brin_deform_tuple().  All you need is a relcache flush to be accessing
garbage.  I haven't dug down thoroughly, but I'd not be surprised if there
were also some dereferences of bd_index, which is equally a dangling
pointer.

            regards, tom lane


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: 9.5 release notes: updates from Andres Freund and Jeff Janes
Next
From: Andres Freund
Date:
Subject: pgsql: Address points made in post-commit review of replication origins