Re: Potential ABI breakage in upcoming minor releases - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Potential ABI breakage in upcoming minor releases
Date
Msg-id 1980993.1731617342@sss.pgh.pa.us
Whole thread Raw
In response to Re: Potential ABI breakage in upcoming minor releases  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Aleksander Alekseev <aleksander@timescale.com> writes:
> The third case is the following:

> ```
> extern TSDLLEXPORT ResultRelInfo *
> ts_catalog_open_indexes(Relation heapRel)
> {
>     ResultRelInfo *resultRelInfo;

>     resultRelInfo = makeNode(ResultRelInfo);
>     resultRelInfo->ri_RangeTableIndex = 0; /* dummy */
>     resultRelInfo->ri_RelationDesc = heapRel;
>     resultRelInfo->ri_TrigDesc = NULL; /* we don't fire triggers */

>     ExecOpenIndices(resultRelInfo, false);

>     return resultRelInfo;
> }
> ```

I'd call that a bug in timescale.  It has no business assuming that
it can skip InitResultRelInfo.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Potential ABI breakage in upcoming minor releases
Next
From: Thomas Munro
Date:
Subject: Re: 039_end_of_wal: error in "xl_tot_len zero" test