Re: More fixes for missing double quotes in the shell - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: More fixes for missing double quotes in the shell
Date
Msg-id 200109300001.f8U01cH09255@candle.pha.pa.us
Whole thread Raw
In response to Re: More fixes for missing double quotes in the shell  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
> Justin writes:
>
> > I agree it's not strictly necessary, but I thought I'd add them in to
> > follow the generic "good programming practise" of always quoting
> > variables in shell script tests.
>
> In my purely personal opinion it's better to be aware of the possible
> values of a variable than to blindly quote everything.  Somewhere you're
> going to run into nested quote situations which cannot be done portably,
> at which point you have to start doing that anyway.

I am not good at remembering what could be in a variabe.  I find it
easier to just quote everything.  If I have embedded quotes, I do
"\"$X\"".  That requires fiddling less often than having values that
need/don't need quote protection.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Trailing semicolons in psql patch
Next
From: Bruce Momjian
Date:
Subject: Re: Trailing semicolons in psql patch