change NAMEDATALEN to 64 - Mailing list pgsql-general

Hi,

We have tables with long names so I modified postgres_ext.h and change
NAMEDATALEN to 64 (originally is 32).

When I do "gmake check", I failed the test on "name", see below.

parallel group (13 tests):  float8 boolean float4 oid int4 int8 char int2 name t
ext varchar bit numeric
     boolean              ... ok
     char                 ... ok
     name                 ... FAILED
     varchar              ... ok
     text                 ... ok
     int2                 ... ok
     int4                 ... ok
     int8                 ... ok
     oid                  ... ok
     float4               ... ok
     float8               ... ok
     bit                  ... ok
     numeric              ... ok
test strings              ... ok


I am attaching the regression.diffs file created by the regression test, which I
don't know how to interprate.

**** The question is, is it ok to fail this regression test since I do change
the NAMEDATALEN ???


thanks,
kathy
*** ./expected/name.out    Tue Jan  4 09:19:34 2000
--- ./results/name.out    Mon Jul 14 15:45:11 2003
***************
*** 28,52 ****
  INSERT INTO NAME_TBL(f1) VALUES ('1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ');
  SELECT '' AS seven, NAME_TBL.*;
   seven |               f1
! -------+---------------------------------
         | ABCDEFGHIJKLMNOP
         | abcdefghijklmnop
         | asdfghjkl;
         | 343f%2a
         | d34aaasdf
         |
!        | 1234567890ABCDEFGHIJKLMNOPQRSTU
  (7 rows)

  SELECT '' AS six, c.f1 FROM NAME_TBL c WHERE c.f1 <> 'ABCDEFGHIJKLMNOP';
   six |               f1
! -----+---------------------------------
       | abcdefghijklmnop
       | asdfghjkl;
       | 343f%2a
       | d34aaasdf
       |
!      | 1234567890ABCDEFGHIJKLMNOPQRSTU
  (6 rows)

  SELECT '' AS one, c.f1 FROM NAME_TBL c WHERE c.f1 = 'ABCDEFGHIJKLMNOP';
--- 28,52 ----
  INSERT INTO NAME_TBL(f1) VALUES ('1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ');
  SELECT '' AS seven, NAME_TBL.*;
   seven |                  f1
! -------+--------------------------------------
         | ABCDEFGHIJKLMNOP
         | abcdefghijklmnop
         | asdfghjkl;
         | 343f%2a
         | d34aaasdf
         |
!        | 1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ
  (7 rows)

  SELECT '' AS six, c.f1 FROM NAME_TBL c WHERE c.f1 <> 'ABCDEFGHIJKLMNOP';
   six |                  f1
! -----+--------------------------------------
       | abcdefghijklmnop
       | asdfghjkl;
       | 343f%2a
       | d34aaasdf
       |
!      | 1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ
  (6 rows)

  SELECT '' AS one, c.f1 FROM NAME_TBL c WHERE c.f1 = 'ABCDEFGHIJKLMNOP';
***************
*** 57,75 ****

  SELECT '' AS three, c.f1 FROM NAME_TBL c WHERE c.f1 < 'ABCDEFGHIJKLMNOP';
   three |               f1
! -------+---------------------------------
         | 343f%2a
         |
!        | 1234567890ABCDEFGHIJKLMNOPQRSTU
  (3 rows)

  SELECT '' AS four, c.f1 FROM NAME_TBL c WHERE c.f1 <= 'ABCDEFGHIJKLMNOP';
   four |               f1
! ------+---------------------------------
        | ABCDEFGHIJKLMNOP
        | 343f%2a
        |
!       | 1234567890ABCDEFGHIJKLMNOPQRSTU
  (4 rows)

  SELECT '' AS three, c.f1 FROM NAME_TBL c WHERE c.f1 > 'ABCDEFGHIJKLMNOP';
--- 57,75 ----

  SELECT '' AS three, c.f1 FROM NAME_TBL c WHERE c.f1 < 'ABCDEFGHIJKLMNOP';
   three |                  f1
! -------+--------------------------------------
         | 343f%2a
         |
!        | 1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ
  (3 rows)

  SELECT '' AS four, c.f1 FROM NAME_TBL c WHERE c.f1 <= 'ABCDEFGHIJKLMNOP';
   four |                  f1
! ------+--------------------------------------
        | ABCDEFGHIJKLMNOP
        | 343f%2a
        |
!       | 1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ
  (4 rows)

  SELECT '' AS three, c.f1 FROM NAME_TBL c WHERE c.f1 > 'ABCDEFGHIJKLMNOP';
***************
*** 91,104 ****

  SELECT '' AS seven, c.f1 FROM NAME_TBL c WHERE c.f1 ~ '.*';
   seven |               f1
! -------+---------------------------------
         | ABCDEFGHIJKLMNOP
         | abcdefghijklmnop
         | asdfghjkl;
         | 343f%2a
         | d34aaasdf
         |
!        | 1234567890ABCDEFGHIJKLMNOPQRSTU
  (7 rows)

  SELECT '' AS zero, c.f1 FROM NAME_TBL c WHERE c.f1 !~ '.*';
--- 91,104 ----

  SELECT '' AS seven, c.f1 FROM NAME_TBL c WHERE c.f1 ~ '.*';
   seven |                  f1
! -------+--------------------------------------
         | ABCDEFGHIJKLMNOP
         | abcdefghijklmnop
         | asdfghjkl;
         | 343f%2a
         | d34aaasdf
         |
!        | 1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ
  (7 rows)

  SELECT '' AS zero, c.f1 FROM NAME_TBL c WHERE c.f1 !~ '.*';
***************
*** 108,117 ****

  SELECT '' AS three, c.f1 FROM NAME_TBL c WHERE c.f1 ~ '[0-9]';
   three |               f1
! -------+---------------------------------
         | 343f%2a
         | d34aaasdf
!        | 1234567890ABCDEFGHIJKLMNOPQRSTU
  (3 rows)

  SELECT '' AS two, c.f1 FROM NAME_TBL c WHERE c.f1 ~ '.*asdf.*';
--- 108,117 ----

  SELECT '' AS three, c.f1 FROM NAME_TBL c WHERE c.f1 ~ '[0-9]';
   three |                  f1
! -------+--------------------------------------
         | 343f%2a
         | d34aaasdf
!        | 1234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ
  (3 rows)

  SELECT '' AS two, c.f1 FROM NAME_TBL c WHERE c.f1 ~ '.*asdf.*';

======================================================================