Re: WIN1252 encoding - backend or not? - Mailing list pgsql-hackers

From Marc G. Fournier
Subject Re: WIN1252 encoding - backend or not?
Date
Msg-id 20041204155327.T9789@ganymede.hub.org
Whole thread Raw
In response to Re: WIN1252 encoding - backend or not?  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: WIN1252 encoding - backend or not?
List pgsql-hackers
On Sat, 4 Dec 2004, Bruce Momjian wrote:

> Tom Lane wrote:
>> Bruce Momjian <pgman@candle.pha.pa.us> writes:
>>> As far as the patch itself, I don't think I ever claimed it was ready
>>> for prime time --- rather, I followed process and it was applied.
>>
>> Applying it on the day before we go RC is claiming that it is ready for
>> prime time.  As Jan already told you, the "process" may include applying
>> patches by default during devel cycle, but it can't work that way in
>> late beta.
>
> OK, so what do we want the process to be?

During Dev Period, Apply whatever comes through if it looks/feels okay

During Beta/Release Cycle, unless you understanding what the patch is 
doing, and how it can affect other aspects of the system, check with 
someone that does before applying ... don't wait for someone to speak out 
against it, but email someone you feel is in the know directly and if you 
don't get a response, assume the patch shouldn't be applied vs should be 
...

Basically, during Beta/Release, we should almost a policy where a third 
party patch needs to be approved by a second committer *before* being 
applied ... and that even applies to Tom >:)  Your own patch, fine ... but 
a third party patch, even submitted by someone who has submitted patch 
previously, should be reviewed/approved by two committers ...




----
Marc G. Fournier           Hub.Org Networking Services (http://www.hub.org)
Email: scrappy@hub.org           Yahoo!: yscrappy              ICQ: 7615664


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: WIN1252 encoding - backend or not?
Next
From: Robert Treat
Date:
Subject: Re: Error: column "nsptablespace" does not exist