Re: --enable-thread-safety on Win32 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: --enable-thread-safety on Win32
Date
Msg-id 200507281508.j6SF8Cs28302@candle.pha.pa.us
Whole thread Raw
In response to Re: --enable-thread-safety on Win32  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> > From: Bruce Momjian [mailto:pgman@candle.pha.pa.us] 
> >> I would like to see how hard it would be to 
> >> add #ifdefs to get the test program to run on Win32.
> 
> > I did manage to get it to compile (though not work fully just yet),
> > however I had to use the full pthreads library rather than our minimal
> > implementation. That's why I question whether we should go this way - an
> > extra dependency (pthreads is not normally on a Windows box, even with
> > Msys) to test an OS that we know 100% for sure is not going to vary in
> > it's thread-safetyness(!) from system to system.
> 
> I agree --- that seems like useless make-work.  Just put a special case
> for Windows into configure.in and be done with it.

OK, but I would then like someone to actually run the tests we do in
thread_test.c and make sure they _would_ pass on Win32.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: --enable-thread-safety on Win32
Next
From: "Dave Page"
Date:
Subject: Re: --enable-thread-safety on Win32