Re: [Patch] - Fix for bug #2558, InitDB failed to run on windows 2003 - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: [Patch] - Fix for bug #2558, InitDB failed to run on windows 2003
Date
Msg-id 20060814164025.GA3110@alvh.no-ip.org
Whole thread Raw
In response to [Patch] - Fix for bug #2558, InitDB failed to run on windows 2003  ("dror" <dror_b@hotmail.com>)
Responses Re: [Patch] - Fix for bug #2558, InitDB failed to run
List pgsql-patches
dror wrote:

> There were two options to solve this issue:
>
> Create a new file , grant a write permission for the Postgres user
> and redirect the output to that file. (EnterpriseDB  use this method)
> Canceling the redirection at all.
>
> I choose the second option and omit the redirection in any case that
> it windows machine and the redirection was sent to DEVNULL.
>
> The only files that I changed are: initDB.c, exec.c and pg_ctl.c

Please submit the changes as patches, instead of the whole files.  Also,
please specify which branch do these patches apply -- is this for 8.1,
or for the current development code?  When checked against the 8.1
pg_ctl.c, the file you sent only contains a regression for a bug fix,
and no change related to what you describe above.

On the other hand, it may be useful to lose the redirection only on the
cases where it fails, so we still have reasonable behavior on non-broken
platforms.  Or maybe there's a better solution.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-patches by date:

Previous
From: "dror"
Date:
Subject: [Patch] - Fix for bug #2558, InitDB failed to run on windows 2003
Next
From: Andrew Dunstan
Date:
Subject: Re: [Patch] - Fix for bug #2558, InitDB failed to run