Re: DTrace probe patch for OS X Leopard - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: DTrace probe patch for OS X Leopard
Date
Msg-id 20080229141048.GD4673@alvh.no-ip.org
Whole thread Raw
In response to Re: DTrace probe patch for OS X Leopard  (Robert Lor <Robert.Lor@Sun.COM>)
Responses Re: DTrace probe patch for OS X Leopard
List pgsql-patches
Robert Lor wrote:

> My concern is that when we start adding more probes (not just the
> backend), we will have to add the following 5 lines in .c files that use
> the Dtrace macros. This seems intrusive and messy to me instead of in a
> centralized place like c.h. What are the disadvantages for keeping the
> way it is now?
>
> #ifdef ENABLE_DTRACE
> #include "utils/probes.h"
> #else
> #include "utils/probes_null.h"
> #endif

Why can't this block be centralized in probes.h?

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

pgsql-patches by date:

Previous
From: Robert Lor
Date:
Subject: Re: DTrace probe patch for OS X Leopard
Next
From: Robert Lor
Date:
Subject: Re: DTrace probe patch for OS X Leopard