hstore-new - hstore-new: Deal with NULL issues in populate_record. - Mailing list pgsql-committers

From andrewsn@pgfoundry.org (User Andrewsn)
Subject hstore-new - hstore-new: Deal with NULL issues in populate_record.
Date
Msg-id 20090914033029.6C0E31071FC8@pgfoundry.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Deal with NULL issues in populate_record. We cope with the various issues
as follows:

 - if we're passed in a null datum, we ensure that every field in the
   returned heaptuple has been through its input function, even the null
   values for fields that weren't set in the hstore

 - if we're passed in a non-null datum heaptupleheader, we assume it's the
   caller's job to have done any validation, domain checks, whatever, and
   so we only call the input function on columns that we're overriding
   with data from the hstore (even if the overriding value is a null)

Add appropriate regression tests.

Modified Files:
--------------
    hstore-new:
        hstore_io.c (r1.5 -> r1.6)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/hstore-new/hstore-new/hstore_io.c?r1=1.5&r2=1.6)
    hstore-new/expected:
        hstore.out (r1.5 -> r1.6)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/hstore-new/hstore-new/expected/hstore.out?r1=1.5&r2=1.6)
    hstore-new/sql:
        hstore.sql (r1.5 -> r1.6)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/hstore-new/hstore-new/sql/hstore.sql?r1=1.5&r2=1.6)

pgsql-committers by date:

Previous
From: andrewsn@pgfoundry.org (User Andrewsn)
Date:
Subject: hstore-new - hstore-new: revisit previous fix; unconditionally set
Next
From: petere@postgresql.org (Peter Eisentraut)
Date:
Subject: pgsql: Print builds don't actually depend on html target (anymore).