Re: actualised funcs typmod patch - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: actualised funcs typmod patch
Date
Msg-id 20091112230753.GM4780@alvh.no-ip.org
Whole thread Raw
In response to actualised funcs typmod patch  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: actualised funcs typmod patch
Re: actualised funcs typmod patch
List pgsql-hackers
Pavel Stehule escribió:
> Hello
> 
> actualised version: enhance check inside sql function

What is this against?  It has a few suspicious chunks, such as

***************
*** 358,364 ****                funcexpr->funcid = funcid;               funcexpr->funcresulttype = rettype;
!               funcexpr->funcresulttypmod = -1;  // TODO STEHULE               funcexpr->funcretset = retset;
    funcexpr->funcformat = COERCE_EXPLICIT_CALL;               funcexpr->args = fargs;
 
--- 365,371 ----                funcexpr->funcid = funcid;               funcexpr->funcresulttype = rettype;
!               funcexpr->funcresulttypmod = rettypmod;               funcexpr->funcretset = retset;
funcexpr->funcformat= COERCE_EXPLICIT_CALL;               funcexpr->args = fargs;
 



This ended up in ./src/backend/parser/parse_func.c.rej

There are other rejects and I'm not sure if I should fix them (at least
the first couple look trivial, though it's against a bunch of code
that last changed in Aug. last year) or ask for a better version ...

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: ALTER TABLE...ALTER COLUMN vs inheritance
Next
From: "Greg Sabino Mullane"
Date:
Subject: Re: EOL for 7.4?