Re: SSI bug? - Mailing list pgsql-hackers

From Dan Ports
Subject Re: SSI bug?
Date
Msg-id 20110217194522.GA98448@csail.mit.edu
Whole thread Raw
In response to Re: SSI bug?  (yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi))
Responses Re: SSI bug?
List pgsql-hackers
On Wed, Feb 16, 2011 at 10:13:35PM +0000, YAMAMOTO Takashi wrote:
> i got the following SEGV when runnning vacuum on a table.
> (the line numbers in predicate.c is different as i have local modifications.)
> oldlocktag.myTarget was NULL.
> it seems that TransferPredicateLocksToNewTarget sometimes use stack garbage
> for newpredlocktag.myTarget.  vacuum on the table succeeded with the attached
> patch.  the latter part of the patch was necessary to avoid targetList
> corruption, which later seems to make DeleteChildTargetLocks loop inifinitely.

Oops. Those are both definitely bugs (and my fault). Your patch looks
correct. Thanks for catching that!

Dan

-- 
Dan R. K. Ports              MIT CSAIL                http://drkp.net/


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Rewrite, normal execution vs. EXPLAIN ANALYZE
Next
From: Robert Haas
Date:
Subject: Re: Add support for logging the current role